linux-kernel - Re: [PATCH] usb: cdns3: Modify the return value of cdns_set_active () to void when CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQqY/+eoVtPJ+i0N@duo.ucw.cz>
Date:   Wed, 20 Sep 2023 09:02:23 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Xiaolei Wang <xiaolei.wang@...driver.com>
Cc:     peter.chen@...nel.org, pawell@...ence.com, rogerq@...nel.org,
        gregkh@...uxfoundation.org, pavel@...x.de,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: cdns3: Modify the return value of cdns_set_active
 () to void when CONFIG_PM_SLEEP is disabled

Hi!

> The return type of cdns_set_active () is inconsistent
> depending on whether CONFIG_PM_SLEEP is enabled, so the
> return value is modified to void type.
> 

Reviewed-by: Pavel Machek <pavel@...x.de>

> Closes: https://lore.kernel.org/all/ZP7lIKUzD68XA91j@duo.ucw.cz/
> Fixes: 2319b9c87fe2 ("usb: cdns3: Put the cdns set active part outside the spin lock")

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)