linux-kernel - RE: [Intel-xe] [PATCH v2 3/4] drm/xe/gsc: add gsc device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY5PR11MB6366C4C1A604269109E1073DEDF9A@CY5PR11MB6366.namprd11.prod.outlook.com>
Date:   Wed, 20 Sep 2023 08:59:44 +0000
From:   "Usyskin, Alexander" <alexander.usyskin@...el.com>
To:     "Vivi, Rodrigo" <rodrigo.vivi@...el.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "De Marchi, Lucas" <lucas.demarchi@...el.com>,
        "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Winkler, Tomas" <tomas.winkler@...el.com>,
        "intel-xe@...ts.freedesktop.org" <intel-xe@...ts.freedesktop.org>
Subject: RE: [Intel-xe] [PATCH v2 3/4] drm/xe/gsc: add gsc device support

> > > diff --git a/drivers/gpu/drm/xe/xe_device.c
> > b/drivers/gpu/drm/xe/xe_device.c
> > > index d6fc06d4c9dc..4d6e2f2b281f 100644
> > > --- a/drivers/gpu/drm/xe/xe_device.c
> > > +++ b/drivers/gpu/drm/xe/xe_device.c
> > > @@ -323,6 +323,8 @@ int xe_device_probe(struct xe_device *xe)
> > >  			goto err_irq_shutdown;
> > >  	}
> > >
> > > +	xe_heci_gsc_init(xe);
> > > +
> >
> > could we place this call earlier in the flow? maybe right after setting up
> mmio?
> > or maybe after pcode init where we confirmed the boot can proceed on
> > discrete?
> 
> Right after xe_irq_install will be ok (as we need working irq to setup)?
> Will try, if this works.
> 

Right after xe_irq_install - not working, but after xe_gt_init_early - it works, will move there in V2

> >
> > >  	err = xe_display_init(xe);
> > >  	if (err)
> > >  		goto err_irq_shutdown;

-- 
Thanks,
Sasha