linux-kernel - Re: [PATCH v3 3/3] riscv: Introduce NAPOT field to PTDUMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <876d3cd5-bb99-edd0-47c0-6dc34c8402d1@ghiti.fr>
Date:   Wed, 20 Sep 2023 11:14:09 +0200
From:   Alexandre Ghiti <alex@...ti.fr>
To:     Yu Chien Peter Lin <peterlin@...estech.com>,
        paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, david@...hat.com, akpm@...ux-foundation.org,
        alexghiti@...osinc.com, bjorn@...osinc.com,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     conor.dooley@...rochip.com
Subject: Re: [PATCH v3 3/3] riscv: Introduce NAPOT field to PTDUMP


On 20/09/2023 05:55, Yu Chien Peter Lin wrote:
> This patch introduces the NAPOT field to PTDUMP, allowing it
> to display the letter "N" for pages that have the 63rd bit set.
>
> Signed-off-by: Yu Chien Peter Lin <peterlin@...estech.com>
> ---
> Changes v1 -> v3
> - no change
> ---
>   arch/riscv/mm/ptdump.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/arch/riscv/mm/ptdump.c b/arch/riscv/mm/ptdump.c
> index 13997cf3fe36..b71f08b91e53 100644
> --- a/arch/riscv/mm/ptdump.c
> +++ b/arch/riscv/mm/ptdump.c
> @@ -136,6 +136,10 @@ struct prot_bits {
>   static const struct prot_bits pte_bits[] = {
>   	{
>   #ifdef CONFIG_64BIT
> +		.mask = _PAGE_NAPOT,
> +		.set = "N",
> +		.clear = ".",
> +	}, {
>   		.mask = _PAGE_MTMASK_SVPBMT,
>   		.set = "MT(%s)",
>   		.clear = "  ..  ",

Nice to see that we actually transparently use napot mappings:

---[ PCI I/O start ]---
0xffff8d7fff000000-0xffff8d7fff010000    0x0000000003000000 64K PTE N   
..     ..   D A G . . W R V

You can add:

Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>

Tested-by: Alexandre Ghiti <alexghiti@...osinc.com>

Thanks for the series, really appreciated!

Alex