linux-kernel - Re: [RFC v2 1/5] mm/migrate: fix do_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <e43c9fb0-1869-4328-a984-33b35caf58ba@app.fastmail.com>
Date:   Wed, 20 Sep 2023 05:36:39 -0400
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Gregory Price" <gourry.memverge@...il.com>,
        linux-mm@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Linux-Arch <linux-arch@...r.kernel.org>,
        linux-api@...r.kernel.org, linux-cxl@...r.kernel.org,
        "Andy Lutomirski" <luto@...nel.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Ingo Molnar" <mingo@...hat.com>, "Borislav Petkov" <bp@...en8.de>,
        "Dave Hansen" <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "Andrew Morton" <akpm@...ux-foundation.org>, x86@...nel.org,
        "Gregory Price" <gregory.price@...verge.com>
Subject: Re: [RFC v2 1/5] mm/migrate: fix do_pages_move for compat pointers

On Tue, Sep 19, 2023, at 19:09, Gregory Price wrote:
> do_pages_move does not handle compat pointers for the page list.
> correctly.  Add in_compat_syscall check and appropriate get_user
> fetch when iterating the page list.
>
> Signed-off-by: Gregory Price <gregory.price@...verge.com>
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Co-developed-by: Arnd Bergmann <arnd@...db.de>

Looks correct to me, thanks for fixing it!

Reviewed-by: Arnd Bergmann <arnd@...db.de>

You can also blame me for breaking it in the first place

Fixes: 5b1b561ba73c ("mm: simplify compat_sys_move_pages")

      Arnd