linux-kernel - Re: [PATCH 09/16] irqchip: irq-xtensa-mx: include header for missing prototype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86v8c5cgv4.wl-maz@kernel.org>
Date:   Wed, 20 Sep 2023 10:51:27 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Chris Zankel <chris@...kel.net>,
        Max Filippov <jcmvbkbc@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 09/16] irqchip: irq-xtensa-mx: include header for missing prototype

On Wed, 20 Sep 2023 06:21:32 +0100,
Randy Dunlap <rdunlap@...radead.org> wrote:
> 
> Add <linux/irqchips/xtensa-mx.h> to provide the function prototype to
> prevent a build warning:
> 
> drivers/irqchip/irq-xtensa-mx.c:166:12: warning: no previous prototype for 'xtensa_mx_init_legacy' [-Wmissing-prototypes]
>   166 | int __init xtensa_mx_init_legacy(struct device_node *interrupt_parent)
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Chris Zankel <chris@...kel.net>
> Cc: Max Filippov <jcmvbkbc@...il.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Marc Zyngier <maz@...nel.org>
> ---
>  drivers/irqchip/irq-xtensa-mx.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -- a/drivers/irqchip/irq-xtensa-mx.c b/drivers/irqchip/irq-xtensa-mx.c
> --- a/drivers/irqchip/irq-xtensa-mx.c
> +++ b/drivers/irqchip/irq-xtensa-mx.c
> @@ -12,6 +12,7 @@
>  #include <linux/irqdomain.h>
>  #include <linux/irq.h>
>  #include <linux/irqchip.h>
> +#include <linux/irqchip/xtensa-mx.h>
>  #include <linux/of.h>
>  
>  #include <asm/mxregs.h>
> 

Acked-by: Marc Zyngier <maz@...nel.org>

It also begs the question of the continuing support for non-DT driven
systems.

Max, Chris: are we any closer to being DT-only on the xtensa front?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.