linux-kernel - Re: [PATCH v2 1/3] printk: Constify name for add_preferred

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d92c84c-512-22d5-58a6-f7a9e554be1@linux.intel.com>
Date:   Wed, 20 Sep 2023 13:56:12 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Tony Lindgren <tony@...mide.com>
cc:     Petr Mladek <pmladek@...e.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        John Ogness <john.ogness@...utronix.de>,
        Andy Shevchenko <andriy.shevchenko@...el.com>,
        Dhruva Gole <d-gole@...com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Johan Hovold <johan@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Vignesh Raghavendra <vigneshr@...com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-serial <linux-serial@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] printk: Constify name for
 add_preferred_console()

On Wed, 20 Sep 2023, Petr Mladek wrote:

> On Tue 2023-09-12 14:03:43, Tony Lindgren wrote:
> > While adding a preferred console handling for serial_core for serial port
> > hardware based device addressing, Jiri suggested we constify name for
> > add_preferred_console(). The gets copied anyways. This allows serial core

Hi Tony,

"The gets copied" seems to lack a word (name?).

-- 
 i.


> > to add a preferred console using serial drv->dev_name without copying it.
> > 
> > Note that constifying options causes changes all over the place because of
> > struct console for match().
> > 
> > Cc: John Ogness <john.ogness@...utronix.de>
> > Cc: Petr Mladek <pmladek@...e.com>
> > Cc: Sergey Senozhatsky <senozhatsky@...omium.org>
> > Cc: Steven Rostedt <rostedt@...dmis.org>
> > Suggested-by: Jiri Slaby <jirislaby@...nel.org>
> > Signed-off-by: Tony Lindgren <tony@...mide.com>
> 
> Makes sense:
> 
> Reviewed-by: Petr Mladek <pmladek@...e.com>
> 
> I assume that this patch would via Greg's tree together with
> the rest of the patchset. Please, tell me if you would prefer to
> queue this via printk tree.
> 
> Best Regards,
> Petr
>