linux-kernel - Re: [PATCH net-next] netdev: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ae9f426-7225-ac4b-4ecd-d53e36dbf365@linux.dev>
Date:   Wed, 20 Sep 2023 12:10:47 +0100
From:   Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To:     Yang Li <yang.lee@...ux.alibaba.com>,
        arkadiusz.kubalewski@...el.com, jiri@...nulli.us
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH net-next] netdev: Remove unneeded semicolon

On 19/09/2023 02:03, Yang Li wrote:
> ./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Hi Yang!
There was a report from Intel's bot too about the issue, could you 
please add the tags from it?

Reported-by: kernel test robot <lkp@...el.com>
Closes: 
https://lore.kernel.org/oe-kbuild-all/202309190540.RFwfIgO7-lkp@intel.com/

Thanks!

> ---
>   drivers/dpll/dpll_netlink.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dpll/dpll_netlink.c b/drivers/dpll/dpll_netlink.c
> index 764437a0661b..e20daba6896a 100644
> --- a/drivers/dpll/dpll_netlink.c
> +++ b/drivers/dpll/dpll_netlink.c
> @@ -844,7 +844,7 @@ dpll_pin_find(u64 clock_id, struct nlattr *mod_name_attr,
>   				return ERR_PTR(-EINVAL);
>   			}
>   			pin_match = pin;
> -		};
> +		}
>   	}
>   	if (!pin_match) {
>   		NL_SET_ERR_MSG(extack, "not found");