linux-kernel - Re: [PATCH] wifi: brcmfmac: firmware: Annotate struct brcmf_fw_request with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169520851058.991705.15337054707712499896.kvalo@kernel.org>
Date:   Wed, 20 Sep 2023 11:15:12 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Arend van Spriel <aspriel@...il.com>,
        Kees Cook <keescook@...omium.org>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Matthias Brugger <mbrugger@...e.com>,
        Hector Martin <marcan@...can.st>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>,
        "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] wifi: brcmfmac: firmware: Annotate struct
 brcmf_fw_request
 with __counted_by

Kees Cook <keescook@...omium.org> wrote:

> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct brcmf_fw_request.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: Arend van Spriel <aspriel@...il.com>
> Cc: Franky Lin <franky.lin@...adcom.com>
> Cc: Hante Meuleman <hante.meuleman@...adcom.com>
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: Matthias Brugger <mbrugger@...e.com>
> Cc: Hector Martin <marcan@...can.st>
> Cc: "Alvin Šipraga" <alsi@...g-olufsen.dk>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: linux-wireless@...r.kernel.org
> Cc: brcm80211-dev-list.pdl@...adcom.com
> Cc: SHA-cyfmac-dev-list@...ineon.com
> Signed-off-by: Kees Cook <keescook@...omium.org>
> Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> Reviewed-by: Matthias Brugger <mbrugger@...e.com>

Patch applied to wireless-next.git, thanks.

45aec443bbb0 wifi: brcmfmac: firmware: Annotate struct brcmf_fw_request with __counted_by

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230915200552.never.642-kees@kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches