linux-kernel - Re: [PATCH 16/16] xtensa: boot/lib: add missing prototypes for functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMo8Bf+UpPzHd_Dc-236sMRcGZ6ynwG3mY-7NCtApbLdzvjsNw@mail.gmail.com>
Date:   Wed, 20 Sep 2023 04:54:42 -0700
From:   Max Filippov <jcmvbkbc@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Chris Zankel <chris@...kel.net>
Subject: Re: [PATCH 16/16] xtensa: boot/lib: add missing prototypes for functions

On Tue, Sep 19, 2023 at 10:21 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Add function prototypes for exit(), zalloc(), and gunzip() to the
> boot library code.

exit() and zalloc() don't need to be public. I've posted a different fix that
makes these two functions static.


> arch/xtensa/boot/lib/zmem.c:8:6: warning: no previous prototype for 'exit' [-Wmissing-prototypes]
>     8 | void exit (void)
> arch/xtensa/boot/lib/zmem.c:13:7: warning: no previous prototype for 'zalloc' [-Wmissing-prototypes]
>    13 | void *zalloc(unsigned size)
> arch/xtensa/boot/lib/zmem.c:35:6: warning: no previous prototype for 'gunzip' [-Wmissing-prototypes]
>    35 | void gunzip (void *dst, int dstlen, unsigned char *src, int *lenp)
>
> Fixes: 4bedea945451 ("xtensa: Architecture support for Tensilica Xtensa Part 2")
> Fixes: e7d163f76665 ("xtensa: Removed local copy of zlib and fixed O= support")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Chris Zankel <chris@...kel.net>
> Cc: Max Filippov <jcmvbkbc@...il.com>
> ---
>  arch/xtensa/boot/lib/zmem.c |    4 ++++
>  1 file changed, 4 insertions(+)

-- 
Thanks.
-- Max