linux-kernel - Re: [PATCH] mfd: ab8500: remove non-existent configuration "#ifdef CONFIG_AB8500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230920121338.GE13143@google.com>
Date:   Wed, 20 Sep 2023 13:13:38 +0100
From:   Lee Jones <lee@...nel.org>
To:     sunying@...iscas.ac.cn
Cc:     linux-kernel@...r.kernel.org, renyanjie01@...il.com,
        pengpeng@...as.ac.cn
Subject: Re: [PATCH] mfd: ab8500: remove non-existent configuration "#ifdef
 CONFIG_AB8500_DEBUG"

On Wed, 13 Sep 2023, sunying@...iscas.ac.cn wrote:

> From: Ying Sun <sunying@...iscas.ac.cn>
> 
> The CONFIG_AB8500_DEBUG has been deleted in
>  [PATCH]mfd: ab8500: Drop debugfs module.

In future please use the following format when referencing commits:

  3d4d1266597c0 ("mfd: ab8500: Drop debugfs module")

I have fixed this for you this time.

> The condition "#ifdef CONFIG_AB8500_DEBUG" in
>  include/linux/mfd/abx500/ab8500.h:502
>  cannot be valid. It is recommended to delete redundant code.
> 
> Suggested-by: Yanjie Ren <renyanjie01@...il.com>
> Signed-off-by: Ying Sun <sunying@...iscas.ac.cn>
> ---
>  include/linux/mfd/abx500/ab8500.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/linux/mfd/abx500/ab8500.h b/include/linux/mfd/abx500/ab8500.h
> index 09fb3c56e7d7..76d326ea8eba 100644
> --- a/include/linux/mfd/abx500/ab8500.h
> +++ b/include/linux/mfd/abx500/ab8500.h
> @@ -499,13 +499,7 @@ static inline int is_ab9540_2p0_or_earlier(struct ab8500 *ab)
>  
>  void ab8500_override_turn_on_stat(u8 mask, u8 set);
>  
> -#ifdef CONFIG_AB8500_DEBUG
> -extern int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size);
> -void ab8500_dump_all_banks(struct device *dev);
> -void ab8500_debug_register_interrupt(int line);
> -#else
>  static inline void ab8500_dump_all_banks(struct device *dev) {}
>  static inline void ab8500_debug_register_interrupt(int line) {}
> -#endif
>  
>  #endif /* MFD_AB8500_H */
> -- 
> 2.17.1
> 

-- 
Lee Jones [李琼斯]