lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <79a526ee-9773-13ad-d36c-4ee1072b115d@proton.me>
Date:   Wed, 20 Sep 2023 13:09:36 +0000
From:   Benno Lossin <benno.lossin@...ton.me>
To:     Manmohan Shukla <manmshuk@...il.com>,
        rust-for-linux@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: error: Markdown style nit

On 06.09.23 22:48, Manmohan Shukla wrote:
> This patch fixes a trivial markdown style nit in the `SAFETY` comment.
> 
> Signed-off-by: Manmohan Shukla <manmshuk@...il.com>
> ---
>   rust/kernel/error.rs | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs
> index 05fcab6abfe6..6233021daa8a 100644
> --- a/rust/kernel/error.rs
> +++ b/rust/kernel/error.rs
> @@ -133,7 +133,7 @@ pub fn to_errno(self) -> core::ffi::c_int {
>       /// Returns the error encoded as a pointer.
>       #[allow(dead_code)]
>       pub(crate) fn to_ptr<T>(self) -> *mut T {
> -        // SAFETY: self.0 is a valid error due to its invariant.
> +        // SAFETY: `self.0` is a valid error due to its invariant.
>           unsafe { bindings::ERR_PTR(self.0.into()) as *mut _ }
>       }
> 
> --
> 2.34.1

Reviewed-by: Benno Lossin <benno.lossin@...ton.me>


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ