linux-kernel - Re: [PATCH v2] arm64: dts: ti: k3-am654-base-board: Add I2C I/O expander

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <917947a7-85bc-10d3-106d-d9f22f169870@ti.com>
Date:   Wed, 20 Sep 2023 08:24:36 -0500
From:   Andrew Davis <afd@...com>
To:     Ravi Gunasekaran <r-gunasekaran@...com>, <nm@...com>,
        <vigneshr@...com>
CC:     <kristo@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am654-base-board: Add I2C I/O
 expander

On 9/20/23 12:38 AM, Ravi Gunasekaran wrote:
> AM654 baseboard has two TCA9554 I/O expander on the WKUP_I2C0 bus.
> The expander at address 0x38 is used to detect daughter cards.
> Add a node for this I/O expander.
> 
> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@...com>
> ---
> Changes from v1:
> ---------------
> * Moved the expander node @38 to appear before the one at address 39.
> * Removed the label pca9554_1 for the node as it is not used.
> 

LGTM,

Reviewed-by: Andrew Davis <afd@...com>

> v1: https://lore.kernel.org/all/20230919050340.16156-1-r-gunasekaran@ti.com/
> 
>   arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index f5c26e9fba98..1637ec5ab5ed 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -369,6 +369,13 @@
>   		ti,enable-vout-discharge;
>   	};
>   
> +	gpio@38 {
> +		compatible = "nxp,pca9554";
> +		reg = <0x38>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +
>   	pca9554: gpio@39 {
>   		compatible = "nxp,pca9554";
>   		reg = <0x39>;
> 
> base-commit: dfa449a58323de195773cf928d99db4130702bf7