linux-kernel - Re: [PATCH] phy: qcom: m31: Remove unwanted qphy->vreg is NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169530637607.106093.6024035938522205244.b4-ty@kernel.org>
Date:   Thu, 21 Sep 2023 16:26:16 +0200
From:   Vinod Koul <vkoul@...nel.org>
To:     agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
        kishon@...nel.org, linux-arm-msm@...r.kernel.org,
        linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Varadarajan Narayanan <quic_varada@...cinc.com>
Subject: Re: [PATCH] phy: qcom: m31: Remove unwanted qphy->vreg is NULL
 check


On Thu, 07 Sep 2023 12:20:52 +0530, Varadarajan Narayanan wrote:
> Fix the following Smatch complaint:
> 	drivers/phy/qualcomm/phy-qcom-m31.c:175 m31usb_phy_init()
> 	warn: variable dereferenced before check 'qphy->vreg' (see line 167)
> 
> drivers/phy/qualcomm/phy-qcom-m31.c
>    166
>    167		ret = regulator_enable(qphy->vreg);
>                                        ^^^^^^^^^^
> Unchecked dereference
> 
> [...]

Applied, thanks!

[1/1] phy: qcom: m31: Remove unwanted qphy->vreg is NULL check
      commit: ecec1de5c58f8f3ab6959fcf8d68752eeb65311d

Best regards,
-- 
~Vinod