linux-kernel - Re: [PATCH v5 3/4] arch/*/io.h: remove ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <c4a96578-b27c-44fa-82ef-1c5bf43b972a@app.fastmail.com>
Date:   Thu, 21 Sep 2023 08:27:14 -0400
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Baoquan He" <bhe@...hat.com>, linux-kernel@...r.kernel.org
Cc:     Linux-Arch <linux-arch@...r.kernel.org>, linux-mm@...ck.org,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        "Jiaxun Yang" <jiaxun.yang@...goat.com>,
        "Michael Ellerman" <mpe@...erman.id.au>,
        "Geert Uytterhoeven" <geert@...ux-m68k.org>,
        "Luis Chamberlain" <mcgrof@...nel.org>,
        "Christoph Hellwig" <hch@...radead.org>,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        "Florian Fainelli" <f.fainelli@...il.com>,
        "Helge Deller" <deller@....de>, linux-alpha@...r.kernel.org,
        linux-hexagon@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
        linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-sh@...r.kernel.org,
        sparclinux@...r.kernel.org
Subject: Re: [PATCH v5 3/4] arch/*/io.h: remove ioremap_uc in some architectures

On Thu, Sep 21, 2023, at 07:04, Baoquan He wrote:
> ioremap_uc() is only meaningful on old x86-32 systems with the PAT
> extension, and on ia64 with its slightly unconventional ioremap()
> behavior. So remove the ioremap_uc() definition in architecutures
> other than x86 and ia64. These architectures all have asm-generic/io.h
> included and will have the default ioremap_uc() definition which
> returns NULL.
>
> This changes the existing behaviour, while no need to worry about
> any breakage because in the only callsite of ioremap_uc(), code
> has been adjusted to eliminate the impact. Please see
> atyfb_setup_generic() of drivers/video/fbdev/aty/atyfb_base.c.
>
> If any new invocation of ioremap_uc() need be added, please consider
> using ioremap() intead or adding a ARCH specific version if necessary.
>
> Signed-off-by: Baoquan He <bhe@...hat.com>
> Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Acked-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)
> Acked-by: Helge Deller <deller@....de>  # parisc
> Cc: linux-alpha@...r.kernel.org
> Cc: linux-hexagon@...r.kernel.org
> Cc: linux-m68k@...ts.linux-m68k.org
> Cc: linux-mips@...r.kernel.org
> Cc: linux-parisc@...r.kernel.org
> Cc: linuxppc-dev@...ts.ozlabs.org
> Cc: linux-sh@...r.kernel.org
> Cc: sparclinux@...r.kernel.org

Acked-by: Arnd Bergmann <arnd@...db.de>