linux-kernel - kernel/stacktrace.c:138: warning: Function parameter or member 'tsk' not described in 'stack_trace_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202309220545.NEMzjh18-lkp@intel.com>
Date:   Fri, 22 Sep 2023 05:54:07 +0800
From:   kernel test robot <lkp@...el.com>
To:     Oliver Glitta <glittao@...il.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Vlastimil Babka <vbabka@...e.cz>
Subject: kernel/stacktrace.c:138: warning: Function parameter or member 'tsk'
 not described in 'stack_trace_save_tsk'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   27bbf45eae9ca98877a2d52a92a188147cd61b07
commit: 5cf909c553e9efed573811de4b3f5172898d5515 mm/slub: use stackdepot to save stack trace in objects
date:   1 year, 6 months ago
config: csky-allnoconfig (https://download.01.org/0day-ci/archive/20230922/202309220545.NEMzjh18-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230922/202309220545.NEMzjh18-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309220545.NEMzjh18-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/stacktrace.c:138: warning: Function parameter or member 'tsk' not described in 'stack_trace_save_tsk'
>> kernel/stacktrace.c:138: warning: Excess function parameter 'task' description in 'stack_trace_save_tsk'


vim +138 kernel/stacktrace.c

214d8ca6ee854f6 Thomas Gleixner 2019-04-25  126  
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  127  /**
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  128   * stack_trace_save_tsk - Save a task stack trace into a storage array
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  129   * @task:	The task to examine
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  130   * @store:	Pointer to storage array
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  131   * @size:	Size of the storage array
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  132   * @skipnr:	Number of entries to skip at the start of the stack trace
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  133   *
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  134   * Return: Number of trace entries stored.
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  135   */
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  136  unsigned int stack_trace_save_tsk(struct task_struct *tsk, unsigned long *store,
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  137  				  unsigned int size, unsigned int skipnr)
214d8ca6ee854f6 Thomas Gleixner 2019-04-25 @138  {
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  139  	stack_trace_consume_fn consume_entry = stack_trace_consume_entry_nosched;
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  140  	struct stacktrace_cookie c = {
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  141  		.store	= store,
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  142  		.size	= size,
b0c51f158455e31 Jiri Slaby      2019-10-30  143  		/* skip this function if they are tracing us */
4b48512c2e9c63b Jiri Slaby      2019-11-11  144  		.skip	= skipnr + (current == tsk),
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  145  	};
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  146  
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  147  	if (!try_get_task_stack(tsk))
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  148  		return 0;
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  149  
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  150  	arch_stack_walk(consume_entry, &c, tsk, NULL);
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  151  	put_task_stack(tsk);
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  152  	return c.len;
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  153  }
214d8ca6ee854f6 Thomas Gleixner 2019-04-25  154  

:::::: The code at line 138 was first introduced by commit
:::::: 214d8ca6ee854f696f75e75511fe66b409e656db stacktrace: Provide common infrastructure

:::::: TO: Thomas Gleixner <tglx@...utronix.de>
:::::: CC: Thomas Gleixner <tglx@...utronix.de>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki