linux-kernel - Re: [PATCH] clk: imx: Select MXC_CLK for CLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1d836c6-4597-4870-8c7f-ebede83c2392@infradead.org>
Date:   Thu, 21 Sep 2023 15:04:13 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Abel Vesa <abel.vesa@...aro.org>, Abel Vesa <abelvesa@...nel.org>,
        Peng Fan <peng.fan@....com>,
        Mike Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>
Cc:     Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Aisheng Dong <aisheng.dong@....com>, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: imx: Select MXC_CLK for CLK_IMX8QXP



On 9/21/23 02:36, Abel Vesa wrote:
> If the i.MX8QXP clock provider is built-in but the MXC_CLK is
> built as module, build fails:
> 
> aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function `imx8_acm_clk_probe':
> clk-imx8-acm.c:(.text+0x3d0): undefined reference to `imx_check_clk_hws'
> 
> Fix that by selecting MXC_CLK in case of CLK_IMX8QXP.
> 
> Fixes: c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
> Closes: https://lore.kernel.org/all/8b77219e-b59e-40f1-96f1-980a0b2debcf@infradead.org/
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>

Acked-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/clk/imx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index f6b82e0b9703..db3bca5f4ec9 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -96,6 +96,7 @@ config CLK_IMX8QXP
>  	depends on (ARCH_MXC && ARM64) || COMPILE_TEST
>  	depends on IMX_SCU && HAVE_ARM_SMCCC
>  	select MXC_CLK_SCU
> +	select MXC_CLK
>  	help
>  	  Build the driver for IMX8QXP SCU based clocks.
>  

-- 
~Randy