linux-kernel - Re: [PATCH V2 3/4] gpio: sprd: Modify the calculation method of eic number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQwomPRn0HaqHMgK@smile.fi.intel.com>
Date:   Thu, 21 Sep 2023 14:27:20 +0300
From:   Andy Shevchenko <andy@...nel.org>
To:     Wenhua Lin <Wenhua.Lin@...soc.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        wenhua lin <wenhua.lin1994@...il.com>,
        Xiongpeng Wu <xiongpeng.wu@...soc.com>
Subject: Re: [PATCH V2 3/4] gpio: sprd: Modify the calculation method of eic
 number

On Thu, Sep 21, 2023 at 05:00:26PM +0800, Wenhua Lin wrote:
> When the soc changes, the corresponding gpio-eic-sprd.c
> code needs to be modified, and the corresponding
> Document must also be modified, which is quite troublesome.
> To avoid modifying the driver file, the number of EICs
> is automatically calculated by matching dts nodes.

> Fixes: 2788938b7946 ("gpio: eic-sprd: Make the irqchip immutable")
> 
> Signed-off-by: Wenhua Lin <Wenhua.Lin@...soc.com>

Same comment as per patch 1. Also, fixes needs to be grouped at the beginning
of the series. (I don't remember seeing Fixes tag in the patch 2.)

...

> +#define SPRD_EIC_VAR_DATA(soc_name)				\

Misindented \

> +static const struct sprd_eic_variant_data soc_name##_eic_dbnc_data = {	\
> +	.type = SPRD_EIC_DEBOUNCE,					\
> +};									\

...

>  	struct sprd_eic *sprd_eic;
>  	struct resource *res;

>  	int ret, i;
> +	u16 num_banks = 0;

Preserve reversed xmas tree order.

-- 
With Best Regards,
Andy Shevchenko