[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZQwl+OXvhA6/x6f1@smile.fi.intel.com>
Date: Thu, 21 Sep 2023 14:16:08 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Philippe Mathieu-Daudé <philmd@...aro.org>
Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>,
linux-mips@...r.kernel.org, Jonas Gorski <jonas.gorski@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jirislaby@...nel.org>,
linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 1/6] serial: 8250: remove AR7 support
On Thu, Sep 21, 2023 at 12:36:05PM +0200, Philippe Mathieu-Daudé wrote:
> On 20/9/23 22:10, Wolfram Sang wrote:
> > --- a/include/uapi/linux/serial_core.h
> > +++ b/include/uapi/linux/serial_core.h
> > @@ -32,7 +32,6 @@
> > #define PORT_XSCALE 15
> > #define PORT_RM9000 16 /* PMC-Sierra RM9xxx internal UART */
> > #define PORT_OCTEON 17 /* Cavium OCTEON internal UART */
> > -#define PORT_AR7 18 /* Texas Instruments AR7 internal UART */
>
> I'm a bit surprised definitions are removed from the uAPI, isn't
> it expected to be very stable? Shouldn't it be better to keep it
> defined but modify the comment, mentioning "obsolete" or "deprecated"?
The numbers up to 20 must stay, they are being used somewhere, setserial
implementation in busybox (IIRC).
NAK.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists