linux-kernel - Re: [PATCH v2] mtd: micron-st: enable lock/unlock for mt25qu512a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4425afd4-c38c-4f27-96a6-9833fe2401b4@linaro.org>
Date:   Thu, 21 Sep 2023 15:35:51 +0100
From:   Tudor Ambarus <tudor.ambarus@...aro.org>
To:     SHUKLA Mamta Ramendra <mamta.shukla@...ca-geosystems.com>,
        "pratyush@...nel.org" <pratyush@...nel.org>,
        "michael@...le.cc" <michael@...le.cc>,
        "miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>,
        "richard@....at" <richard@....at>,
        "vigneshr@...com" <vigneshr@...com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     GEO-CHHER-bsp-development 
        <bsp-development.geo@...ca-geosystems.com>
Subject: Re: [PATCH v2] mtd: micron-st: enable lock/unlock for mt25qu512a



On 9/21/23 15:31, Tudor Ambarus wrote:
cut
> 
> So the first commit will look like:
> diff --git a/drivers/mtd/spi-nor/micron-st.c
> b/drivers/mtd/spi-nor/micron-st.c
> index 4afcfc57c896..a8da1f18e335 100644
> --- a/drivers/mtd/spi-nor/micron-st.c
> +++ b/drivers/mtd/spi-nor/micron-st.c
> @@ -405,9 +405,6 @@ static const struct flash_info st_nor_parts[] = {
>         }, {
>                 .id = SNOR_ID(0x20, 0xbb, 0x20, 0x10, 0x44, 0x00),
>                 .name = "mt25qu512a",
> -               .size = SZ_64M,
> -               .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ,
> -               .fixup_flags = SPI_NOR_4B_OPCODES,

since we removed the 4b-opcodes flag here,
>                 .mfr_flags = USE_FSR,
>         }, {
>                 .id = SNOR_ID(0x20, 0xbb, 0x20),
> 
> and the second one will add just the BP support, something like:
> diff --git a/drivers/mtd/spi-nor/micron-st.c
> b/drivers/mtd/spi-nor/micron-st.c
> index a8da1f18e335..fdafbfa0f936 100644
> --- a/drivers/mtd/spi-nor/micron-st.c
> +++ b/drivers/mtd/spi-nor/micron-st.c
> @@ -405,6 +405,8 @@ static const struct flash_info st_nor_parts[] = {
>         }, {
>                 .id = SNOR_ID(0x20, 0xbb, 0x20, 0x10, 0x44, 0x00),
>                 .name = "mt25qu512a",
> +               .flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB |
> SPI_NOR_4BIT_BP |
> +                        SPI_NOR_BP3_SR_BIT6,
>                 .mfr_flags = USE_FSR,
>         }, {
>                 .id = SNOR_ID(0x20, 0xbb, 0x20),
> 
> Of course, I expect you to run again the mtd_debug tests and also verify
> the locking. Thanks!

would also be good if you can also verify that 4BAIT SFDP table is
present and you still use the 4B opcodes after the change.

> 
> Cheers,
> ta
>