linux-kernel - Re: [PATCH v2 net] net: dsa: mv88e6xxx: Avoid EEPROM timeout when EEPROM is absent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMZO5AjMGA5TtTJH2b7Fs_C3bj84UZr378FVsp5S+ver8_WpQ@mail.gmail.com>
Date:   Thu, 21 Sep 2023 09:58:47 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     kuba@...nel.org
Cc:     andrew@...n.ch, f.fainelli@...il.com, olteanv@...il.com,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        l00g33k@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Fabio Estevam <festevam@...x.de>,
        Florian Fainelli <florian.fainelli@...adcom.com>
Subject: Re: [PATCH v2 net] net: dsa: mv88e6xxx: Avoid EEPROM timeout when
 EEPROM is absent

On Wed, Sep 20, 2023 at 3:47 PM Fabio Estevam <festevam@...il.com> wrote:

> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -3012,14 +3012,16 @@ static void mv88e6xxx_hardware_reset(struct mv88e6xxx_chip *chip)
>                  * from the wrong location resulting in the switch booting
>                  * to wrong mode and inoperable.
>                  */
> -               mv88e6xxx_g1_wait_eeprom_done(chip);
> +               if (chip->info->ops->get_eeprom)
> +                       mv88e6xxx_g2_eeprom_wait(chip);

Just realized that I should also remove the
mv88e6xxx_g1_wait_eeprom_done() definition, as it becomes unused now.

I will send a v3 with such a change, but will wait for more comments first.