linux-kernel - Re: [patch V3 10/30] x86/microcode/intel: Unify microcode apply() functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230921100717.GGZQwV1bIb+jHyXIwX@fat_crate.local>
Date:   Thu, 21 Sep 2023 12:07:17 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        "Chang S. Bae" <chang.seok.bae@...el.com>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Nikolay Borisov <nik.borisov@...e.com>
Subject: Re: [patch V3 10/30] x86/microcode/intel: Unify microcode apply()
 functions

On Tue, Sep 12, 2023 at 09:57:59AM +0200, Thomas Gleixner wrote:
> Deduplicate the early and late apply() functions.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
>  arch/x86/kernel/cpu/microcode/intel.c |  105 +++++++++++-----------------------
>  1 file changed, 36 insertions(+), 69 deletions(-)
> 
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -294,12 +294,11 @@ static __init struct microcode_intel *sc
>  	return size ? NULL : patch;
>  }
>  
> -static enum ucode_state apply_microcode_early(struct ucode_cpu_info *uci, bool early)
> +static enum ucode_state apply_microcode(struct ucode_cpu_info *uci, struct microcode_intel *mc,

Err, we have

struct microcode_ops.apply_microcode()

already. Can we disambiguate those pls?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette