linux-kernel - Re: [PATCH] drm/ssd130x: Drop _helper prefix from struct drm_*_helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bee087f0-878c-480a-b72b-6b3dd69b84a6@suse.de>
Date:   Thu, 21 Sep 2023 10:55:04 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Maxime Ripard <mripard@...nel.org>
Cc:     dri-devel@...ts.freedesktop.org,
        Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/ssd130x: Drop _helper prefix from struct
 drm_*_helper_funcs callbacks

Hi

Am 21.09.23 um 10:46 schrieb Geert Uytterhoeven:
[...]
> 
>>> Anything else confuses the casual reader. Perhaps the real question is whether
>>> the structures should have "helper" in their name in the first place?
>>
>> Those structures are meant for functions used by the helpers, they are not
>> helper functions.
> 
> That might be how they started, but to me it looks like all these helpers
> are no longer helpers, but part of the core...

They are in library modules. You can write a DRM driver without 
_helper_funcs, see i915. It's just a really hard sell to upstream nowadays.

Best regards
Thomas

> 
> Gr{oetje,eeting}s,
> 
>                          Geert
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)