linux-kernel - Re: [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Sep 2023 19:31:40 +0530
From:   Vignesh Raman <vignesh.raman@...labora.com>
To:     Helen Koike <helen.koike@...labora.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     guilherme.gallo@...labora.com, sergi.blanch.torne@...labora.com,
        daniels@...labora.com, emma@...olt.net, robdclark@...il.com,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Maxime Ripard <mripard@...nel.org>,
        David Heidelberg <david.heidelberg@...labora.com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host
 mode

Hi maintainers,

On 12/09/23 22:39, Helen Koike wrote:
> 
> 
> On 11/09/2023 13:15, Vignesh Raman wrote:
>> Due to the presence of the fastboot micro cable in the CI farm,
>> it causes the hardware to remain in gadget mode instead of host mode.
>> So it doesn't find the network, which results in failure to mount root
>> fs via NFS.
> 
> Just a context for others, this was part of this patch series 
> https://lore.kernel.org/r/20230908152225.432139-1-vignesh.raman@collabora.com
> 
>>
>> Add an overlay dtso file that sets the dr_mode to host, allowing the
>> USB controllers to work in host mode. With commit 15d16d6dadf6
>> ("kbuild: Add generic rule to apply fdtoverlay"), overlay target can
>> be used to simplify the build of DTB overlays. It uses fdtoverlay to
>> merge base device tree with the overlay dtso. apq8016-sbc-usb-host.dtb
>> file can be used by drm-ci, mesa-ci.
>>
>> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>> Suggested-by: Maxime Ripard <mripard@...nel.org>
>> Signed-off-by: Helen Koike <helen.koike@...labora.com>
>> Signed-off-by: David Heidelberg <david.heidelberg@...labora.com>
>> Signed-off-by: Vignesh Raman <vignesh.raman@...labora.com>
> 
> Acked-by: Helen Koike <helen.koike@...labora.com>
> 
> 
>> ---
>>   arch/arm64/boot/dts/qcom/Makefile                  | 4 ++++
>>   arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++
>>   2 files changed, 12 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile 
>> b/arch/arm64/boot/dts/qcom/Makefile
>> index 2cca20563a1d..99190a6ba6ff 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -1,5 +1,9 @@
>>   # SPDX-License-Identifier: GPL-2.0
>>   dtb-$(CONFIG_ARCH_QCOM)    += apq8016-sbc.dtb
>> +
>> +apq8016-sbc-usb-host-dtbs    := apq8016-sbc.dtb 
>> apq8016-sbc-usb-host.dtbo
>> +
>> +dtb-$(CONFIG_ARCH_QCOM)    += apq8016-sbc-usb-host.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)    += apq8016-sbc-d3-camera-mezzanine.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)    += apq8039-t2.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)    += 
>> apq8094-sony-xperia-kitakami-karin_windy.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso 
>> b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
>> new file mode 100644
>> index 000000000000..a82c26b7eae8
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
>> @@ -0,0 +1,8 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +
>> +/dts-v1/;
>> +/plugin/;
>> +
>> +&usb {
>> +         dr_mode = "host";
>> +};

Please could you review this patch. Thanks.

Regards,
Vignesh