[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGXv+5G6fYh8wULmERrxbJyXmdDJjthnUEqT+_3nTTTndLf15Q@mail.gmail.com>
Date: Thu, 21 Sep 2023 17:09:06 +0800
From: Chen-Yu Tsai <wenst@...omium.org>
To: Lee Jones <lee@...nel.org>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Mark Brown <broonie@...nel.org>,
Zhiyong Tao <zhiyong.tao@...iatek.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v3 10/12] regulator: mt6358: Add missing regulators for MT6366
On Tue, Sep 19, 2023 at 9:55 PM Lee Jones <lee@...nel.org> wrote:
>
> On Tue, 19 Sep 2023, Chen-Yu Tsai wrote:
>
> > When support for the MT6366 PMIC regulators was added, it was assumed
> > that it had the same functionality as MT6358. In reality there are
> > differences. A few regulators have different ranges, or were renamed
> > and repurposed, or removed altogether.
> >
> > Add the 3 regulators that were missing from the original submission.
> > These are added for completeness. VSRAM_CORE is not used in existing
> > projects. VM18 and VMDDR feed DRAM related consumers, and are not used
> > in-kernel.
> >
> > Signed-off-by: Chen-Yu Tsai <wenst@...omium.org>
> > ---
> > Changes since v2:
> > - Linear range selector values fixed
> >
> > Angelo's reviewed-by was dropped.
> >
> > drivers/regulator/mt6358-regulator.c | 20 ++++++++++++++++++++
>
> > include/linux/mfd/mt6358/registers.h | 17 +++++++++++++++++
>
> Acked-by: Lee Jones <lee@...nel.org>
Thanks! Could you also take a look at another patch this series is
based on and ack that one?
It's "regulator: mt6358: Add output voltage fine tuning to fixed regulators",
with message ID "20230913082919.1631287-3-wenst@...omium.org" [1].
ChenYu
[1] https://lore.kernel.org/linux-arm-kernel/20230913082919.1631287-4-wenst@chromium.org/
>
> > include/linux/regulator/mt6358-regulator.h | 3 +++
> > 3 files changed, 40 insertions(+)
>
> [...]
>
> --
> Lee Jones [李琼斯]
Powered by blists - more mailing lists