[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=XrhPxrYRP4A4vcKyq+euhfyWq3rzs2egXB51fdFNSLZQ@mail.gmail.com>
Date: Thu, 21 Sep 2023 11:47:21 -0700
From: Doug Anderson <dianders@...omium.org>
To: dri-devel@...ts.freedesktop.org, Maxime Ripard <mripard@...nel.org>
Cc: airlied@...il.com, daniel@...ll.ch, javierm@...hat.com,
linux-kernel@...r.kernel.org
Subject: Re: [RFT PATCH 4/6] drm/ssd130x: Call drm_atomic_helper_shutdown() at
remove time
Hi,
On Fri, Sep 1, 2023 at 4:40 PM Douglas Anderson <dianders@...omium.org> wrote:
>
> Based on grepping through the source code, this driver appears to be
> missing a call to drm_atomic_helper_shutdown() at remove time. Let's
> add it.
>
> The fact that we should call drm_atomic_helper_shutdown() in the case
> of OS driver remove comes straight out of the kernel doc "driver
> instance overview" in drm_drv.c.
>
> Suggested-by: Maxime Ripard <mripard@...nel.org>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
> This commit is only compile-time tested.
>
> NOTE: I'm not 100% sure this is the correct thing to do, but I _think_
> so. Please shout if you know better.
>
> drivers/gpu/drm/solomon/ssd130x.c | 1 +
> 1 file changed, 1 insertion(+)
Landed this to drm-misc-next. Since I wasn't 100% sure, if someone
finds that this is bad after-the-fact, we can certainly revert.
10c8204c8b17 drm/ssd130x: Call drm_atomic_helper_shutdown() at remove time
Powered by blists - more mailing lists