linux-kernel - Re: [PATCH v2] ath9k: clean up function ath9k_hif_usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169528344376.1539628.7025381317587339647.kvalo@kernel.org>
Date:   Thu, 21 Sep 2023 08:04:05 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Dongliang Mu <dzm91@...t.edu.cn>
Cc:     Toke Høiland-Jørgensen <toke@...e.dk>,
        hust-os-kernel-patches@...glegroups.com,
        Dongliang Mu <dzm91@...t.edu.cn>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ath9k: clean up function ath9k_hif_usb_resume

Dongliang Mu <dzm91@...t.edu.cn> wrote:

> In ath9k_hif_usb_resume, the error handling code calls
> ath9k_hif_usb_dealloc_urbs twice in different paths.
> 
> To unify the error handling code, we move the else branch before
> the if branch and drop one level of indentation of the if branch.
> 
> In addition, move the ret variable at the end of variable declarations
> to be reverse x-mas tree order.
> 
> Note that this patch does not incur any functionability change.
> 
> Signed-off-by: Dongliang Mu <dzm91@...t.edu.cn>
> Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>
> Acked-by: Toke Høiland-Jørgensen <toke@...e.dk>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

Patch applied to ath-next branch of ath.git, thanks.

dc73b2059354 wifi: ath9k: clean up function ath9k_hif_usb_resume

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230905013556.2595854-1-dzm91@hust.edu.cn/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches