linux-kernel - Re: [PATCH] remoteproc: mediatek: Refactor single core check and fix retrocompatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXv+5Hr1woRL5z6b4k6e+FQKaVyoUmP4vAt=RrEgjEwq8bUhw@mail.gmail.com>
Date:   Thu, 21 Sep 2023 12:09:37 +0800
From:   Chen-Yu Tsai <wenst@...omium.org>
To:     Laura Nao <laura.nao@...labora.com>
Cc:     angelogioacchino.delregno@...labora.com, andersson@...nel.org,
        kernel@...labora.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-remoteproc@...r.kernel.org, mathieu.poirier@...aro.org,
        matthias.bgg@...il.com, tinghan.shen@...iatek.com
Subject: Re: [PATCH] remoteproc: mediatek: Refactor single core check and fix retrocompatibility

On Wed, Sep 20, 2023 at 11:03 PM Laura Nao <laura.nao@...labora.com> wrote:
>
> On 9/19/23 11:23, AngeloGioacchino Del Regno wrote:
> > In older devicetrees we had the ChromeOS EC in a node called "cros-ec"
> > instead of the newer "cros-ec-rpmsg", but this driver is now checking
> > only for the latter, breaking compatibility with those.
> >
> > Besides, we can check if the SCP is single or dual core by simply
> > walking through the children of the main SCP node and checking if
> > if there's more than one "mediatek,scp-core" compatible node.
> >
> > Fixes: 1fdbf0cdde98 ("remoteproc: mediatek: Probe SCP cluster on multi-core SCP")
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> > ---
> >   drivers/remoteproc/mtk_scp.c | 18 +++++++-----------
> >   1 file changed, 7 insertions(+), 11 deletions(-)
> >
>
> Tested on asurada (spherion) and jacuzzi (juniper). The issue was detected by KernelCI, so:
>
> Reported-by: "kernelci.org bot" <bot@...nelci.org>
> Tested-by: Laura Nao <laura.nao@...labora.com>

Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>
Tested-by: Chen-Yu Tsai <wenst@...omium.org>

on Hayato (MT8192) and Juniper (MT8183).