[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c0ec8d22-534b-4962-b5b2-ff6391b32b1b@lunn.ch>
Date: Thu, 21 Sep 2023 18:32:31 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Roger Quadros <rogerq@...nel.org>
Cc: MD Danish Anwar <danishanwar@...com>,
Vignesh Raghavendra <vigneshr@...com>,
Richard Cochran <richardcochran@...il.com>,
Paolo Abeni <pabeni@...hat.com>,
Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>,
"David S. Miller" <davem@...emloft.net>, vladimir.oltean@....com,
Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, srk@...com, r-gunasekaran@...com,
Roger Quadros <rogerq@...com>
Subject: Re: [PATCH net-next v2] net: ti: icssg_prueth: add TAPRIO offload
support
> > + if (!netif_running(ndev)) {
> > + netdev_err(ndev, "interface is down, link speed unknown\n");
> > + return -ENETDOWN;
> > + }
>
> Do we really need this?
The error message suggests it is wrong anyway. netif_running() being
true means it is admin up. But the carrier might be down, and so the
link speed is unknown. So maybe this should be using netif_carrier_ok() ?
Andrew
Powered by blists - more mailing lists