[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADnq5_OV7L4_z5mhAq8x8nV4+yp_wGhyVeg1MrKAVoSbMVV1uw@mail.gmail.com>
Date: Fri, 22 Sep 2023 13:42:20 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Kees Cook <keescook@...omium.org>
Cc: David Airlie <airlied@...il.com>,
Tejas Upadhyay <tejas.upadhyay@...el.com>,
Emma Anholt <emma@...olt.net>, Tom Rix <trix@...hat.com>,
llvm@...ts.linux.dev, dri-devel@...ts.freedesktop.org,
Chris Wilson <chris@...is-wilson.co.uk>,
Prike Liang <Prike.Liang@....com>,
Huang Rui <ray.huang@....com>,
Gerd Hoffmann <kraxel@...hat.com>,
Andrzej Hajda <andrzej.hajda@...el.com>,
Marijn Suijten <marijn.suijten@...ainline.org>,
Matthew Brost <matthew.brost@...el.com>,
Karol Herbst <kherbst@...hat.com>,
Neil Armstrong <neil.armstrong@...aro.org>,
amd-gfx@...ts.freedesktop.org,
Kuogee Hsieh <quic_khsieh@...cinc.com>,
Nathan Chancellor <nathan@...nel.org>,
VMware Graphics Reviewers
<linux-graphics-maintainer@...are.com>,
Ben Skeggs <bskeggs@...hat.com>,
Andi Shyti <andi.shyti@...ux.intel.com>,
nouveau@...ts.freedesktop.org, David Airlie <airlied@...hat.com>,
virtualization@...ts.linux-foundation.org,
linux-hardening@...r.kernel.org, Lijo Lazar <lijo.lazar@....com>,
Yifan Zhang <yifan1.zhang@....com>,
linux-arm-msm@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
Kevin Wang <kevin1.wang@....com>,
Abhinav Kumar <quic_abhinavk@...cinc.com>,
Melissa Wen <mwen@...lia.com>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Gurchetan Singh <gurchetansingh@...omium.org>,
Maxime Ripard <mripard@...nel.org>,
Rodrigo Vivi <rodrigo.vivi@...el.com>,
Evan Quan <evan.quan@....com>, Sean Paul <sean@...rly.run>,
Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
Xiaojian Du <Xiaojian.Du@....com>, Le Ma <le.ma@....com>,
freedreno@...ts.freedesktop.org,
Bjorn Andersson <andersson@...nel.org>,
"Pan, Xinhui" <Xinhui.Pan@....com>,
Nick Desaulniers <ndesaulniers@...gle.com>,
linux-kernel@...r.kernel.org,
Alex Deucher <alexander.deucher@....com>,
Nirmoy Das <nirmoy.das@...el.com>, Lang Yu <Lang.Yu@....com>,
Christian König <christian.koenig@....com>,
John Harrison <john.c.harrison@...el.com>,
Hawking Zhang <Hawking.Zhang@....com>
Subject: Re: [PATCH 2/9] drm/amdgpu/discovery: Annotate struct ip_hw_instance
with __counted_by
On Fri, Sep 22, 2023 at 1:33 PM Kees Cook <keescook@...omium.org> wrote:
>
> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct ip_hw_instance.
>
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: "Christian König" <christian.koenig@....com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@....com>
> Cc: David Airlie <airlied@...il.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Hawking Zhang <Hawking.Zhang@....com>
> Cc: amd-gfx@...ts.freedesktop.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Kees Cook <keescook@...omium.org>
Acked-by: Alex Deucher <alexander.deucher@....com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> index d1bc7b212520..be4c97a3d7bf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -662,7 +662,7 @@ struct ip_hw_instance {
> u8 harvest;
>
> int num_base_addresses;
> - u32 base_addr[];
> + u32 base_addr[] __counted_by(num_base_addresses);
> };
>
> struct ip_hw_id {
> --
> 2.34.1
>
Powered by blists - more mailing lists