linux-kernel - Re: [PATCH v2 2/4] arm64: dts: ti: k3-am654-base-board: add ICSSG2 Ethernet support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Sep 2023 09:58:42 +0530
From:   MD Danish Anwar <danishanwar@...com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Vignesh Raghavendra <vigneshr@...com>, Nishanth Menon <nm@...com>,
        <afd@...com>, Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Tero Kristo <kristo@...nel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <srk@...com>,
        <r-gunasekaran@...com>
Subject: Re: [PATCH v2 2/4] arm64: dts: ti: k3-am654-base-board: add ICSSG2
 Ethernet support

On 21/09/23 21:40, Andrew Lunn wrote:
>> +	/* Dual Ethernet application node on PRU-ICSSG2 */
> 
> How relevant is "Dual Ethernet" here? You are talking of adding
> switchdev support, and runtime swapping the application. All these
> properties should be valid for the switch application as well?
> 

All these properties and nodes are valid for switch mode as well. The
comment of "Dual Ethernet application node" is mainly to describe the
two physical ports that are present on the AM654x-EVM.

> In fact, you are describing hardware here, so the application should
> not actually matter.
> 
> So maybe this comment should be:
> 
> Ethernet node on PRU-ICSSG2
> 

Sure, this makes more sense. I will change the comment.

> 	Andrew

-- 
Thanks and Regards,
Danish