linux-kernel - Re: [PATCH] i3c: svc: Annotate struct svc_i3c_xfer with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230922195537.2ed8c479@xps-13>
Date:   Fri, 22 Sep 2023 19:55:37 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Conor Culhane <conor.culhane@...vaco.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-i3c@...ts.infradead.org,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] i3c: svc: Annotate struct svc_i3c_xfer with
 __counted_by

Hi,

keescook@...omium.org wrote on Fri, 22 Sep 2023 10:50:23 -0700:

> Prepare for the coming implementation by GCC and Clang of the __counted_by
> attribute. Flexible array members annotated with __counted_by can have
> their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
> (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
> 
> As found with Coccinelle[1], add __counted_by for struct svc_i3c_xfer.
> 
> [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
> 
> Cc: Miquel Raynal <miquel.raynal@...tlin.com>
> Cc: Conor Culhane <conor.culhane@...vaco.com>
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: linux-i3c@...ts.infradead.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>

Thanks,
Miquèl