linux-kernel - drivers/opp/core.c:2304: warning: Function parameter or member 'opp_table' not described in '_opp_set_config_regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202309230220.2XPQXigR-lkp@intel.com>
Date:   Sat, 23 Sep 2023 02:05:03 +0800
From:   kernel test robot <lkp@...el.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: drivers/opp/core.c:2304: warning: Function parameter or member
 'opp_table' not described in '_opp_set_config_regulators_helper'

Hi Viresh,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   dc912ba91b7e2fa74650a0fc22cccf0e0d50f371
commit: aee3352f6ecf8cfad1f1ee5838cfc4d37c6b8f75 OPP: Add support for config_regulators() helper
date:   1 year, 3 months ago
config: csky-defconfig (https://download.01.org/0day-ci/archive/20230923/202309230220.2XPQXigR-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230923/202309230220.2XPQXigR-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309230220.2XPQXigR-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/opp/core.c:1989: warning: Function parameter or member 'opp_table' not described in '_opp_set_supported_hw'
   drivers/opp/core.c:1989: warning: Excess function parameter 'dev' description in '_opp_set_supported_hw'
   drivers/opp/core.c:2032: warning: Function parameter or member 'opp_table' not described in '_opp_set_prop_name'
   drivers/opp/core.c:2032: warning: Excess function parameter 'dev' description in '_opp_set_prop_name'
   drivers/opp/core.c:2073: warning: Function parameter or member 'opp_table' not described in '_opp_set_regulators'
   drivers/opp/core.c:2073: warning: Excess function parameter 'count' description in '_opp_set_regulators'
   drivers/opp/core.c:2186: warning: Function parameter or member 'opp_table' not described in '_opp_set_clknames'
   drivers/opp/core.c:2250: warning: Function parameter or member 'opp_table' not described in '_opp_register_set_opp_helper'
>> drivers/opp/core.c:2304: warning: Function parameter or member 'opp_table' not described in '_opp_set_config_regulators_helper'
   drivers/opp/core.c:2368: warning: Function parameter or member 'opp_table' not described in '_opp_attach_genpd'
   drivers/opp/core.c:2602: warning: Function parameter or member 'token' not described in 'dev_pm_opp_clear_config'
   drivers/opp/core.c:2602: warning: Excess function parameter 'opp_table' description in 'dev_pm_opp_clear_config'


vim +2304 drivers/opp/core.c

  2292	
  2293	/**
  2294	 * _opp_set_config_regulators_helper() - Register custom set regulator helper.
  2295	 * @dev: Device for which the helper is getting registered.
  2296	 * @config_regulators: Custom set regulator helper.
  2297	 *
  2298	 * This is useful to support platforms with multiple regulators per device.
  2299	 *
  2300	 * This must be called before any OPPs are initialized for the device.
  2301	 */
  2302	static int _opp_set_config_regulators_helper(struct opp_table *opp_table,
  2303			struct device *dev, config_regulators_t config_regulators)
> 2304	{
  2305		/* Another CPU that shares the OPP table has set the helper ? */
  2306		if (!opp_table->config_regulators)
  2307			opp_table->config_regulators = config_regulators;
  2308	
  2309		return 0;
  2310	}
  2311	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki