linux-kernel - Re: [PATCH net-next 01/18] net/smc: decouple ism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7dad8b72ec94d27378eca87fea4cb0c86b8c361.camel@linux.ibm.com>
Date:   Fri, 22 Sep 2023 20:13:13 +0200
From:   Gerd Bayer <gbayer@...ux.ibm.com>
To:     Wen Gu <guwen@...ux.alibaba.com>, Simon Horman <horms@...nel.org>
Cc:     kgraul@...ux.ibm.com, wenjia@...ux.ibm.com, jaka@...ux.ibm.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, alibuda@...ux.alibaba.com,
        tonylu@...ux.alibaba.com, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 01/18] net/smc: decouple ism_dev from SMC-D
 device dump

On Fri, 2023-09-22 at 16:05 +0800, Wen Gu wrote:
> On 2023/9/22 04:41, Simon Horman wrote:
> > On Tue, Sep 19, 2023 at 10:41:45PM +0800, Wen Gu wrote:
> > 
> > priv_dev is uninitialised here.
> > 
> > > -       smc_set_pci_values(to_pci_dev(ism->dev.parent),
> > > &smc_pci_dev);
> > > +       if (smcd->ops->get_dev)
> > > +               priv_dev = smcd->ops->get_dev(smcd);
> > 
> > It is conditionally initialised here.
> > 
> > > +       if (priv_dev->parent)
> > 
> > But unconditionally dereferenced here.
> > 
> > As flagged by clang-16 W=1, and Smatch
> > 
> 
> Hi Simon. Yes, I fixed it in v3. Thank you!

Hi Wen Gu,

seems like there is some email filter at work. Neither v2 nor v3 made
it to the netdev mailing list - nor to patchwork.kernel.org.
There's traces of Wenjia's replies and your replies to her - but not
the original mail.

Could you please check? Thanks!
Gerd