linux-kernel - Re: [PATCH v3] x86/hyperv: Restrict get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Sep 2023 18:41:55 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Saurabh Sengar <ssengar@...ux.microsoft.com>
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
        decui@...rosoft.com, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
        hpa@...or.com, linux-hyperv@...r.kernel.org,
        linux-kernel@...r.kernel.org, mikelley@...rosoft.com,
        vkuznets@...hat.com, ssengar@...rosoft.com
Subject: Re: [PATCH v3] x86/hyperv: Restrict get_vtl to only VTL platforms

On Tue, Sep 19, 2023 at 09:04:35PM -0700, Saurabh Sengar wrote:
> When Linux runs in a non-default VTL (CONFIG_HYPERV_VTL_MODE=y),
> get_vtl() must never fail as its return value is used in negotiations
> with the host. In the more generic case, (CONFIG_HYPERV_VTL_MODE=n) the
> VTL is always zero so there's no need to do the hypercall.
> 
> Make get_vtl() BUG() in case of failure and put the implementation under
> "if IS_ENABLED(CONFIG_HYPERV_VTL_MODE)" to avoid the call altogether in
> the most generic use case.
> 
> Signed-off-by: Saurabh Sengar <ssengar@...ux.microsoft.com>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Applied to hyperv-fixes. Thanks.