linux-kernel - Re: [PATCH] drivers/watchdog: fix checkpatch error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4067f87f-c982-05c7-a198-49482da22817@roeck-us.net>
Date:   Fri, 22 Sep 2023 13:33:47 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Nikita Bune <w1s2d5@...il.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        Masami Hiramatsu <mhiramat@...nel.org>
Cc:     linux-watchdog@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/watchdog: fix checkpatch error

On 9/22/23 13:10, Nikita Bune wrote:
> Fix checkpatch ERROR: do not initialise statics to 0
> 
> Signed-off-by: Nikita Bune <w1s2d5@...il.com>

Not applying. Please stop submitting such cosmetic patches.
Also please note that the subject should start with "<subsystem>: <driver>:".

Guenter

> ---
>   drivers/watchdog/uniphier_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/uniphier_wdt.c b/drivers/watchdog/uniphier_wdt.c
> index 8e9242c23022..7a080600d865 100644
> --- a/drivers/watchdog/uniphier_wdt.c
> +++ b/drivers/watchdog/uniphier_wdt.c
> @@ -41,7 +41,7 @@
>   #define WDT_PERIOD_MIN			1
>   #define WDT_PERIOD_MAX			128
>   
> -static unsigned int timeout = 0;
> +static unsigned int timeout;
>   static bool nowayout = WATCHDOG_NOWAYOUT;
>   
>   struct uniphier_wdt_dev {