[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b7a715aa-eb74-4909-8dae-88d063bee28b@linaro.org>
Date: Fri, 22 Sep 2023 22:18:40 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Stephan Gerhold <stephan@...hold.net>,
Bjorn Andersson <andersson@...nel.org>
Cc: Andy Gross <agross@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: apq8016-sbc-d3-camera: Use more
generic node names
On 22/09/2023 16:11, Stephan Gerhold wrote:
> Add "regulator" to the node names of the fixed regulators, and drop the
> "_rear" part of the camera node name since it is not part of the class
> of the device (which is simply "camera").
>
> Signed-off-by: Stephan Gerhold <stephan@...hold.net>
> ---
> &cci_i2c0 {
> - camera_rear@3b {
> + camera@3b {
> compatible = "ovti,ov5640";
> reg = <0x3b>;
You could consider a follow-up patch here along the lines of
orientation = <2>
to indicate the camera is External.
This shows up with a pretty name in libcamera based applications then.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Powered by blists - more mailing lists