linux-kernel - Re: [PATCH v2] sched: fix warning in bandwidth distribution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABk29Nv8FPOaTeOsJMNrsiZYSGdLeCRazBsD6nLSwdZ+ha8NZg@mail.gmail.com>
Date:   Fri, 22 Sep 2023 15:58:48 -0700
From:   Josh Don <joshdon@...gle.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Valentin Schneider <vschneid@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] sched: fix warning in bandwidth distribution

On Fri, Sep 22, 2023 at 1:13 AM Ingo Molnar <mingo@...nel.org> wrote:
>
> So instead of uglifying the code with seldom-tested !CONFIG_SMP #ifdefs,
> please fold the !SMP code into SMP code: make ->throttled_csd_list
> unconditional in a preparatory patch (even if it's essentially unused on
> !SMP), then add what is basically your v1 patch as a second patch in the
> series to fix the bug.
>
> We want to unify as much of the SMP and !SMP codepaths as possible, even
> when it casuses a bit of runtime overhead for !SMP.

Yep, makes perfect sense, I'll respin this patch.

Thanks,
Josh