[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <181402d1-1f62-46f1-9306-14688e12a1a3@quicinc.com>
Date: Fri, 22 Sep 2023 13:51:34 +0800
From: Tengfei Fan <quic_tengfan@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
<andersson@...nel.org>, <tglx@...utronix.de>, <maz@...nel.org>,
<robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
<conor+dt@...nel.org>, <catalin.marinas@....com>, <will@...nel.org>
CC: <geert+renesas@...der.be>, <arnd@...db.de>,
<neil.armstrong@...aro.org>, <nfraprado@...labora.com>,
<rafal@...ecki.pl>, <peng.fan@....com>,
<linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<devicetree@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <quic_tsoni@...cinc.com>,
<quic_shashim@...cinc.com>, <quic_kaushalk@...cinc.com>,
<quic_tdas@...cinc.com>, <quic_tingweiz@...cinc.com>,
<quic_aiquny@...cinc.com>, <quic_ajipan@...cinc.com>,
<kernel@...cinc.com>
Subject: Re: [PATCH v3 3/5] arm64: dts: qcom: sm4450: Add RPMH and Global
clock
在 9/20/2023 6:00 PM, Konrad Dybcio 写道:
>
>
> On 9/20/23 08:54, Tengfei Fan wrote:
>> Add device node for RPMH and Global clock controller on Qualcomm
>> SM4450 platform.
>>
>> Signed-off-by: Ajit Pandey <quic_ajipan@...cinc.com>
>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sm4450.dtsi | 23 +++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm4450.dtsi
>> b/arch/arm64/boot/dts/qcom/sm4450.dtsi
>> index 3d9d3b5e9510..c27f17a41699 100644
>> --- a/arch/arm64/boot/dts/qcom/sm4450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm4450.dtsi
>> @@ -3,6 +3,8 @@
>> * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights
>> reserved.
>> */
>> +#include <dt-bindings/clock/qcom,rpmh.h>
>> +#include <dt-bindings/clock/qcom,sm4450-gcc.h>
> These should be sorted alphabetically.
>
Hi Konrad,
I think these included header files already were sorted alphabetically(r
-> s), so there are unnecessary for adjust them again, right?
> [...]
>
>> + rpmhcc: clock-controller {
>> + compatible = "qcom,sm4450-rpmh-clk";
>> + #clock-cells = <1>;
>> + clock-names = "xo";
>> + clocks = <&xo_board>;
> property
> property-names
>
> Konrad
--
Thx and BRs,
Tengfei Fan
Powered by blists - more mailing lists