[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20230922075929.31074-1-xingxing.luo@unisoc.com>
Date: Fri, 22 Sep 2023 15:59:29 +0800
From: Xingxing Luo <xingxing.luo@...soc.com>
To: <b-liu@...com>
CC: <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<xingxing0070.luo@...il.com>, <Zhiyong.Liu@...soc.com>,
<Cixi.Geng1@...soc.com>, <Orson.Zhai@...soc.com>,
<zhang.lyra@...il.com>
Subject: [PATCH] usb: musb: Modify the "HWVers" register address
musb HWVers rgister address is not 0x69, if we operate the
wrong address 0x69, it will cause a kernel crash, because
there is no register corresponding to this address in the
additional control register of musb. In fact, HWVers has
been defined in musb_register.h, and the name is
"MUSB_HWVERS", so We need to use this macro instead of 0x69.
Fixes: c2365ce5d5a0 ("usb: musb: replace hard coded registers with defines")
Cc: stable@...r.kernel.org
Signed-off-by: Xingxing Luo <xingxing.luo@...soc.com>
---
drivers/usb/musb/musb_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_debugfs.c b/drivers/usb/musb/musb_debugfs.c
index 78c726a71b17..2d623284edf6 100644
--- a/drivers/usb/musb/musb_debugfs.c
+++ b/drivers/usb/musb/musb_debugfs.c
@@ -39,7 +39,7 @@ static const struct musb_register_map musb_regmap[] = {
{ "IntrUsbE", MUSB_INTRUSBE, 8 },
{ "DevCtl", MUSB_DEVCTL, 8 },
{ "VControl", 0x68, 32 },
- { "HWVers", 0x69, 16 },
+ { "HWVers", MUSB_HWVERS, 16 },
{ "LinkInfo", MUSB_LINKINFO, 8 },
{ "VPLen", MUSB_VPLEN, 8 },
{ "HS_EOF1", MUSB_HS_EOF1, 8 },
--
2.17.1
Powered by blists - more mailing lists