lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AM6PR04MB634103F226B69ADD41255FCBE7FFA@AM6PR04MB6341.eurprd04.prod.outlook.com>
Date:   Fri, 22 Sep 2023 01:33:00 +0000
From:   Ming Qian <ming.qian@....com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        "Mirela Rabulea (OSS)" <mirela.rabulea@....nxp.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>
CC:     "mchehab@...nel.org" <mchehab@...nel.org>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "X.H. Bao" <xiahong.bao@....com>, Eagle Zhou <eagle.zhou@....com>,
        Tao Jiang <tao.jiang_2@....com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [EXT] Re: [PATCH v2 2/2] dt-bindings: media: imx-jpeg: Assign
 slot for imx jpeg encoder/decoder

>From: Krzysztof Kozlowski <krzk@...nel.org>
>Sent: 2023年9月21日 17:55
>To: Ming Qian <ming.qian@....com>; Mirela Rabulea (OSS)
><mirela.rabulea@....nxp.com>; robh+dt@...nel.org; shawnguo@...nel.org
>Cc: mchehab@...nel.org; hverkuil-cisco@...all.nl; s.hauer@...gutronix.de;
>kernel@...gutronix.de; festevam@...il.com; X.H. Bao
><xiahong.bao@....com>; Eagle Zhou <eagle.zhou@....com>; Tao Jiang
><tao.jiang_2@....com>; dl-linux-imx <linux-imx@....com>; linux-
>media@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-
>kernel@...ts.infradead.org
>Subject: [EXT] Re: [PATCH v2 2/2] dt-bindings: media: imx-jpeg: Assign slot for
>imx jpeg encoder/decoder
>
>Caution: This is an external email. Please take care when clicking links or
>opening attachments. When in doubt, report the message using the 'Report
>this email' button
>
>
>On 21/09/2023 08:36, Ming Qian wrote:
>> There are total 4 slots available in the IP, and we only need to use
>> one slot in one os, assign a single slot, configure interrupt and
>> power domain only for 1 slot, not for the all 4 slots.
>
>Please use scripts/get_maintainers.pl to get a list of necessary people and lists
>to CC. It might happen, that command when run on an older kernel, gives you
>outdated entries. Therefore please be sure you base your patches on recent
>Linux kernel.
>
>You missed at least devicetree list (maybe more), so this won't be tested by
>automated tooling. Performing review on untested code might be a waste of
>time, thus I will skip this patch entirely till you follow the process allowing the
>patch to be tested.
>
>Please kindly resend and include all necessary To/Cc entries.
>
>>
>> Signed-off-by: Ming Qian <ming.qian@....com>
>> ---
>>  .../bindings/media/nxp,imx8-jpeg.yaml         | 40 ++++++++-----------
>>  1 file changed, 16 insertions(+), 24 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> index 3d9d1db37040..5f0e2fc1ea9c 100644
>> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
>> @@ -32,25 +32,27 @@ properties:
>>      maxItems: 1
>>
>>    interrupts:
>> -    description: |
>> -      There are 4 slots available in the IP, which the driver may use
>> -      If a certain slot is used, it should have an associated interrupt
>> -      The interrupt with index i is assumed to be for slot i
>> -    minItems: 1               # At least one slot is needed by the driver
>> -    maxItems: 4               # The IP has 4 slots available for use
>> +    description:
>> +      Interrupt number for slot
>> +    maxItems: 1
>>
>>    power-domains:
>>      description:
>>        List of phandle and PM domain specifier as documented in
>>        Documentation/devicetree/bindings/power/power_domain.txt
>> -    minItems: 2               # Wrapper and 1 slot
>> -    maxItems: 5               # Wrapper and 4 slots
>> +    minItems: 1               # VPUMIX
>> +    maxItems: 2               # Wrapper and 1 slot
>> +
>> +  slot:
>> +    description:
>> +      Integer number of slot index used. the value range is from 0 to
>> + 3
>
>Don't you have here obvious errors reported by testing? Did you test this?
>
>Best regards,
>Krzysztof

Hi Krzysztof,
    Can you point out which test error? I run the dt_binding_check and didn't get any error.

make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
  LINT    Documentation/devicetree/bindings
  CHKDT   Documentation/devicetree/bindings/processed-schema.json
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  DTEX    Documentation/devicetree/bindings/media/nxp,imx8-jpeg.example.dts
  DTC_CHK Documentation/devicetree/bindings/media/nxp,imx8-jpeg.example.dtb

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ