linux-kernel - Re: [PATCH 2/3] media: i2c: drop check because i2c_unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <169537047013.2915094.9440302098198891842@ping.linuxembedded.co.uk>
Date:   Fri, 22 Sep 2023 09:14:30 +0100
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-renesas-soc@...r.kernel.org
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] media: i2c: drop check because i2c_unregister_device() is NULL safe

Hi Wolfram,

Quoting Wolfram Sang (2023-09-22 09:04:19)
> No need to check the argument of i2c_unregister_device() because the
> function itself does it.

Well spotted!

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
> Build tested only. Please apply to your tree.
> 
>  drivers/media/i2c/rdacm20.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
> index f4e2e2f3972a..b4647bda8c21 100644
> --- a/drivers/media/i2c/rdacm20.c
> +++ b/drivers/media/i2c/rdacm20.c
> @@ -625,8 +625,7 @@ static int rdacm20_probe(struct i2c_client *client)
>         v4l2_ctrl_handler_free(&dev->ctrls);
>  error:
>         media_entity_cleanup(&dev->sd.entity);
> -       if (dev->sensor)
> -               i2c_unregister_device(dev->sensor);
> +       i2c_unregister_device(dev->sensor);
>  
>         dev_err(&client->dev, "probe failed\n");
>  
> -- 
> 2.30.2
>