linux-kernel - Re: [PATCH] firmware: ti_sci: Mark driver as non removable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230921092438.mnpvyjsa4qe7bkhk@dhruva>
Date:   Thu, 21 Sep 2023 14:54:38 +0530
From:   Dhruva Gole <d-gole@...com>
To:     Nishanth Menon <nm@...com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <u.kleine-koenig@...gutronix.de>,
        Tero Kristo <kristo@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>, <vibhore@...com>
Subject: Re: [PATCH] firmware: ti_sci: Mark driver as non removable

On Sep 20, 2023 at 07:59:04 -0500, Nishanth Menon wrote:
> On 22:47-20230907, Dhruva Gole wrote:
> > The TI-SCI message protocol provides a way to communicate between
> > various compute processors with a central system controller entity. It
> > provides the fundamental device management capability and clock control
> > in the SOCs that it's used in.
> > 
> > Ensure that the driver isn't unbound by suppressing its bind and unbind
> > sysfs attributes. As the driver is built-in there is no way to remove
> > device once bound.
> > 
> > We can also remove the ti_sci_remove call along with the
> > ti_sci_debugfs_destroy as there are no callers for it any longer.
> > 
> > Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> > Suggested-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > Signed-off-by: Dhruva Gole <d-gole@...com>
> 
> Add Reported-by and Closes tags
> 
> Also please address the comment from Uwe on improving the commit message

Sent V2 patch here:
https://lore.kernel.org/all/20230921091025.133130-1-d-gole@ti.com/T/#u

> 
> [...]
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

-- 
Best regards,
Dhruva Gole <d-gole@...com>