linux-kernel - Re: [PATCH] IB/qib: replace deprecated strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169537859190.3339131.7912668348878588064.b4-ty@kernel.org>
Date:   Fri, 22 Sep 2023 13:29:51 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Justin Stitt <justinstitt@...gle.com>
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] IB/qib: replace deprecated strncpy


On Thu, 21 Sep 2023 07:58:48 +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1]
> and as such we should prefer more robust and less ambiguous string
> interfaces.
> 
> We know `txselect_list` is expected to be NUL-terminated based on its
> use in `param_get_string()`:
> | int param_get_string(char *buffer, const struct kernel_param *kp)
> | {
> | 	const struct kparam_string *kps = kp->str;
> | 	return scnprintf(buffer, PAGE_SIZE, "%s\n", kps->string);
> | }
> 
> [...]

Applied, thanks!

[1/1] IB/qib: replace deprecated strncpy
      https://git.kernel.org/rdma/rdma/c/cb7ab7854bc709

Best regards,
-- 
Leon Romanovsky <leon@...nel.org>