linux-kernel - Re: [PATCH] xhci: Keep interrupt disabled in initialization until host is running.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023092236-cogwheel-skied-0841@gregkh>
Date:   Fri, 22 Sep 2023 12:39:50 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Prashanth K <quic_prashk@...cinc.com>
Cc:     linux-kernel@...r.kernel.org, Hongyu Xie <xy521521@...il.com>,
        Mathias Nyman <mathias.nyman@...el.com>, stable@...nel.org,
        Hongyu Xie <xiehongyu1@...inos.cn>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>
Subject: Re: [PATCH] xhci: Keep interrupt disabled in initialization until
 host is running.

On Fri, Sep 22, 2023 at 04:03:26PM +0530, Prashanth K wrote:
> 
> 
> On 22-09-23 04:00 pm, Greg Kroah-Hartman wrote:
> > On Fri, Sep 22, 2023 at 02:51:41PM +0530, Prashanth K wrote:
> > > From: Hongyu Xie <xy521521@...il.com>
> > > 
> > > [ Upstream commit 808925075fb750804a60ff0710614466c396db4 ]
> > > 
> > > irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared
> > > in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it.
> > > It's possible that you will receive thousands of interrupt requests
> > > after initialization for 2.0 roothub. And you will get a lot of
> > > warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be
> > > disabled?". This amount of interrupt requests will cause the entire
> > > system to freeze.
> > > This problem was first found on a device with ASM2142 host controller
> > > on it.
> > > 
> > > [tidy up old code while moving it, reword header -Mathias]
> > > 
> > > Cc: stable@...nel.org
> > > Signed-off-by: Hongyu Xie <xiehongyu1@...inos.cn>
> > > Signed-off-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
> > > Link: https://lore.kernel.org/r/20220623111945.1557702-2-mathias.nyman@linux.intel.com
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > ---
> > >   drivers/usb/host/xhci.c | 34 +++++++++++++++++++++-------------
> > >   1 file changed, 21 insertions(+), 13 deletions(-)
> > 
> > What stable kernel(s) are you asking this to be applied to?
> > 
> > greg k-h
> Need this patch on v5.15, I had cc'ed "stable@...nel.org # 5.15", but looks
> like it didn't work. Should I resend this with SOB and CC tags?

Yes please.

thanks,

greg k-h