linux-kernel - Re: [PATCH] mtd: map_ram: prevent use of point and unpoint when NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230922145121.578332-1-miquel.raynal@bootlin.com>
Date:   Fri, 22 Sep 2023 16:51:21 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Shivamurthy Shastri <shivamurthy.shastri@...utronix.de>,
        miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
        linux-mtd@...ts.infradead.org
Cc:     linus.walleij@...aro.org, b.spranger@...utronix.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: map_ram: prevent use of point and unpoint when NO_XIP is set

On Tue, 2023-09-19 at 11:33:20 UTC, Shivamurthy Shastri wrote:
> When the DT property no-unaligned-direct-access is set, map->phys is set
> to NO_XIP. With this property set, the flash should not be exposed
> directly to MTD users, since it cannot be mapped.
> 
> map_ram() exposes the flash direct access unconditionally which leads to
> access errors (when the bus width does not match the RAM width).
> 
> Therefore do not set point and unpoint when NO_XIP is set.
> 
> Signed-off-by: Shivamurthy Shastri <shivamurthy.shastri@...utronix.de>
> Reviewed-by: Benedikt Spranger <b.spranger@...utronix.de>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel