linux-kernel - Re: [patch V3 19/30] x86/microcode: Clarify the late load logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230922155921.GJZQ252T5TbOVCYDc1@fat_crate.local>
Date:   Fri, 22 Sep 2023 17:59:21 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        "Chang S. Bae" <chang.seok.bae@...el.com>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Nikolay Borisov <nik.borisov@...e.com>
Subject: Re: [patch V3 19/30] x86/microcode: Clarify the late load logic

On Tue, Sep 12, 2023 at 09:58:13AM +0200, Thomas Gleixner wrote:
> +	ret = microcode_ops->request_microcode_fw(0, &microcode_pdev->dev);
> +	if (ret != UCODE_NEW)
> +		return ret == UCODE_NFOUND ? -ENOENT : -EBADFD;

I know this is short but let's make it more boring and readable pls:

	if (ret != UCODE_NEW) {
		if (ret == UCODE_NFOUND)
			return -ENOENT;
		else
			return -EBADFD;
	}

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette