linux-kernel - Re: [PATCH 2/2] pinctrl: qcom: msm8974: Add MPM pin mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1769487.VLH7GnMWUR@z3ntu.xyz>
Date:   Sat, 23 Sep 2023 13:52:44 +0200
From:   Luca Weiss <luca@...tu.xyz>
To:     linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Matti Lehtimäki <matti.lehtimaki@...il.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Matti Lehtimäki <matti.lehtimaki@...il.com>
Subject: Re: [PATCH 2/2] pinctrl: qcom: msm8974: Add MPM pin mappings

On Samstag, 23. September 2023 00:40:27 CEST Matti Lehtimäki wrote:
> Add pin <-> wakeirq mappings to allow for waking up the AP from sleep
> through MPM-connected pins.
> 
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@...il.com>

Based on the discussion in the 8226 patch, this looks correct, compared with 
downstream arch/arm/boot/dts/msm8974pro-pm.dtsi.

Reviewed-by: Luca Weiss <luca@...tu.xyz>

> ---
>  drivers/pinctrl/qcom/pinctrl-msm8x74.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm8x74.c
> b/drivers/pinctrl/qcom/pinctrl-msm8x74.c index d5fe62992849..238c83f6ec4f
> 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm8x74.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm8x74.c
> @@ -1045,6 +1045,16 @@ static const struct msm_pingroup msm8x74_groups[] = {
> 
>  #define NUM_GPIO_PINGROUPS 146
> 
> +static const struct msm_gpio_wakeirq_map msm8x74_mpm_map[] = {
> +	{ 1, 4 }, { 5, 5 }, { 9, 6 }, { 18, 7 }, { 20, 8 }, { 24, 9 },
> +	{ 27, 10 }, { 28, 11 }, { 34, 12 }, { 35, 13 }, { 37, 14 }, { 42, 15 
},
> +	{ 44, 16 }, { 46, 17 }, { 50, 18 }, { 54, 19 }, { 59, 20 }, { 61, 21 
},
> +	{ 62, 22 }, { 64, 23 }, { 65, 24 }, { 66, 25 }, { 67, 26 }, { 68, 27 
},
> +	{ 71, 28 }, { 72, 29 }, { 73, 30 }, { 74, 31 }, { 75, 32 }, { 77, 33 
},
> +	{ 79, 34 }, { 80, 35 }, { 82, 36 }, { 86, 37 }, { 92, 38 }, { 93, 39 
},
> +	{ 95, 40 }, { 102, 3 }, { 144, 41 },
> +};
> +
>  static const struct msm_pinctrl_soc_data msm8x74_pinctrl = {
>  	.pins = msm8x74_pins,
>  	.npins = ARRAY_SIZE(msm8x74_pins),
> @@ -1053,6 +1063,8 @@ static const struct msm_pinctrl_soc_data
> msm8x74_pinctrl = { .groups = msm8x74_groups,
>  	.ngroups = ARRAY_SIZE(msm8x74_groups),
>  	.ngpios = NUM_GPIO_PINGROUPS,
> +	.wakeirq_map = msm8x74_mpm_map,
> +	.nwakeirq_map = ARRAY_SIZE(msm8x74_mpm_map),
>  };
> 
>  static int msm8x74_pinctrl_probe(struct platform_device *pdev)