linux-kernel - Re: [PATCH v1] iio: adc: MCP3564: fix the static checker warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 24 Sep 2023 14:24:52 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     <marius.cristea@...rochip.com>
Cc:     <lars@...afoo.de>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] iio: adc: MCP3564: fix the static checker warning

On Mon, 18 Sep 2023 10:56:33 +0300
<marius.cristea@...rochip.com> wrote:

> From: Marius Cristea <marius.cristea@...rochip.com>
> 
> The patch 33ec3e5fc1ea: "iio: adc: adding support for MCP3564 ADC"
> from Aug 29, 2023 (linux-next), leads to the following Smatch static
> checker warning:
> 
>         drivers/iio/adc/mcp3564.c:1426 mcp3564_probe()
>         warn: address of NULL pointer 'indio_dev'
> 
> drivers/iio/adc/mcp3564.c
>     1421         struct iio_dev *indio_dev;
>     1422         struct mcp3564_state *adc;
>     1423
>     1424         indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*adc));
>     1425         if (!indio_dev) {
> --> 1426                 dev_err_probe(&indio_dev->dev, PTR_ERR(indio_dev),  
>                                        ^^^^^^^^^^^^^^^
> 
> Fixes: 33ec3e5fc1ea (iio: adc: adding support for MCP3564 ADC)
> Signed-off-by: Marius Cristea <marius.cristea@...rochip.com>
Applied to the togreg branch of iio.git as that's where this driver is at the moment.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/mcp3564.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/adc/mcp3564.c b/drivers/iio/adc/mcp3564.c
> index 64145f4ae55c..9ede1a5d5d7b 100644
> --- a/drivers/iio/adc/mcp3564.c
> +++ b/drivers/iio/adc/mcp3564.c
> @@ -1422,11 +1422,8 @@ static int mcp3564_probe(struct spi_device *spi)
>  	struct mcp3564_state *adc;
>  
>  	indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*adc));
> -	if (!indio_dev) {
> -		dev_err_probe(&indio_dev->dev, PTR_ERR(indio_dev),
> -			      "Can't allocate iio device\n");
> +	if (!indio_dev)
>  		return -ENOMEM;
> -	}
>  
>  	adc = iio_priv(indio_dev);
>  	adc->spi = spi;
> 
> base-commit: 22da192f43f7d302d02644efa192ba5a05d935c9