linux-kernel - Re: linux-next: Signed-off-bys missing for commit in the mm-hotfixes tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230924164201.863ad5e63a2d555f6d33254c@linux-foundation.org>
Date:   Sun, 24 Sep 2023 16:42:01 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Ryan Roberts <ryan.roberts@....com>
Subject: Re: linux-next: Signed-off-bys missing for commit in the
 mm-hotfixes tree

On Mon, 25 Sep 2023 07:50:26 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> Hi all,
> 
> Commit
> 
>   48248e468270 ("mm: hugetlb: add huge page size param to set_huge_pte_at()")
> 
> is missing Signed-off-bys from its author and committer.
> 
> It looks like the commit message has been truncated.

Ah, thanks.  The changelog has a stray ^---$:

: If CONFIG_DEBUG_VM is enabled, we do at least get a BUG(), but otherwise,
: it will dereference a bad pointer in page_folio():
: 
:     static inline struct folio *hugetlb_swap_entry_to_folio(swp_entry_t entry)
:     {
:         VM_BUG_ON(!is_migration_entry(entry) && !is_hwpoison_entry(entry));
: 
:         return page_folio(pfn_to_page(swp_offset_pfn(entry)));
:     }
: 
: 
: Fix

<chomp>

: ---
: 
: The simplest fix would have been to revert the dodgy cleanup commit
: 18f3962953e4 ("mm: hugetlb: kill set_huge_swap_pte_at()"), but since
: things have moved on, this would have required an audit of all the new
: set_huge_pte_at() call sites to see if they should be converted to
: set_huge_swap_pte_at().  As per the original intent of the change, it
: would also leave us open to future bugs when people invariably get it
: wrong and call the wrong helper.

That's actually from the [0/n] intro, which I pasted into the [1/n]
changelog.

It gets through my scripts OK
(https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-hugetlb-add-huge-page-size-param-to-set_huge_pte_at.patch),
but it looks like git-quiltimport did the deed.

Let me add a check for that...