| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230925163200.GA1469001-robh@kernel.org>
Date: Mon, 25 Sep 2023 11:32:00 -0500
From: Rob Herring <robh@...nel.org>
To: Ming Qian <ming.qian@....com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
"Mirela Rabulea (OSS)" <mirela.rabulea@....nxp.com>,
"shawnguo@...nel.org" <shawnguo@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
"mchehab@...nel.org" <mchehab@...nel.org>,
"hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
"kernel@...gutronix.de" <kernel@...gutronix.de>,
"festevam@...il.com" <festevam@...il.com>,
"X.H. Bao" <xiahong.bao@....com>, Eagle Zhou <eagle.zhou@....com>,
Tao Jiang <tao.jiang_2@....com>,
dl-linux-imx <linux-imx@....com>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign
slot for imx jpeg encoder/decoder
On Mon, Sep 25, 2023 at 08:48:01AM +0000, Ming Qian wrote:
> >From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >Sent: 2023年9月25日 16:33
> >To: Ming Qian <ming.qian@....com>; Mirela Rabulea (OSS)
> ><mirela.rabulea@....nxp.com>; robh+dt@...nel.org; shawnguo@...nel.org
> >Cc: krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
> >mchehab@...nel.org; hverkuil-cisco@...all.nl; s.hauer@...gutronix.de;
> >kernel@...gutronix.de; festevam@...il.com; X.H. Bao
> ><xiahong.bao@....com>; Eagle Zhou <eagle.zhou@....com>; Tao Jiang
> ><tao.jiang_2@....com>; dl-linux-imx <linux-imx@....com>;
> >devicetree@...r.kernel.org; linux-media@...r.kernel.org; linux-
> >kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> >Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg: Assign slot
> >for imx jpeg encoder/decoder
> >
> >Caution: This is an external email. Please take care when clicking links or
> >opening attachments. When in doubt, report the message using the 'Report
> >this email' button
> >
> >
> >On 25/09/2023 10:20, Ming Qian wrote:
> >>> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >>> Sent: 2023年9月25日 16:14
> >>> To: Ming Qian <ming.qian@....com>; Mirela Rabulea (OSS)
> >>> <mirela.rabulea@....nxp.com>; robh+dt@...nel.org;
> >shawnguo@...nel.org
> >>> Cc: krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
> >>> mchehab@...nel.org; hverkuil-cisco@...all.nl; s.hauer@...gutronix.de;
> >>> kernel@...gutronix.de; festevam@...il.com; X.H. Bao
> >>> <xiahong.bao@....com>; Eagle Zhou <eagle.zhou@....com>; Tao Jiang
> >>> <tao.jiang_2@....com>; dl-linux-imx <linux-imx@....com>;
> >>> devicetree@...r.kernel.org; linux-media@...r.kernel.org; linux-
> >>> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> >>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg:
> >>> Assign slot for imx jpeg encoder/decoder
> >>>
> >>> Caution: This is an external email. Please take care when clicking
> >>> links or opening attachments. When in doubt, report the message using
> >>> the 'Report this email' button
> >>>
> >>>
> >>> On 25/09/2023 10:13, Ming Qian wrote:
> >>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >>>>> Sent: 2023年9月25日 16:10
> >>>>> To: Ming Qian <ming.qian@....com>; Mirela Rabulea (OSS)
> >>>>> <mirela.rabulea@....nxp.com>; robh+dt@...nel.org;
> >>> shawnguo@...nel.org
> >>>>> Cc: krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
> >>>>> mchehab@...nel.org; hverkuil-cisco@...all.nl;
> >>>>> s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com;
> >>>>> X.H. Bao <xiahong.bao@....com>; Eagle Zhou <eagle.zhou@....com>;
> >>>>> Tao Jiang <tao.jiang_2@....com>; dl-linux-imx <linux-imx@....com>;
> >>>>> devicetree@...r.kernel.org; linux-media@...r.kernel.org; linux-
> >>>>> kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> >>>>> Subject: Re: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg:
> >>>>> Assign slot for imx jpeg encoder/decoder
> >>>>>
> >>>>> Caution: This is an external email. Please take care when clicking
> >>>>> links or opening attachments. When in doubt, report the message
> >>>>> using the 'Report this email' button
> >>>>>
> >>>>>
> >>>>> On 25/09/2023 10:07, Ming Qian wrote:
> >>>>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >>>>>>> Sent: 2023年9月25日 16:02
> >>>>>>> To: Ming Qian <ming.qian@....com>; Mirela Rabulea (OSS)
> >>>>>>> <mirela.rabulea@....nxp.com>; robh+dt@...nel.org;
> >>>>> shawnguo@...nel.org
> >>>>>>> Cc: krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
> >>>>>>> mchehab@...nel.org; hverkuil-cisco@...all.nl;
> >>>>>>> s.hauer@...gutronix.de; kernel@...gutronix.de;
> >>>>>>> festevam@...il.com; X.H. Bao <xiahong.bao@....com>; Eagle Zhou
> >>>>>>> <eagle.zhou@....com>; Tao Jiang <tao.jiang_2@....com>;
> >>>>>>> dl-linux-imx <linux-imx@....com>; devicetree@...r.kernel.org;
> >>>>>>> linux-media@...r.kernel.org; linux- kernel@...r.kernel.org;
> >>>>>>> linux-arm-kernel@...ts.infradead.org
> >>>>>>> Subject: [EXT] Re: [PATCH v3 2/2] dt-bindings: media: imx-jpeg:
> >>>>>>> Assign slot for imx jpeg encoder/decoder
> >>>>>>>
> >>>>>>> Caution: This is an external email. Please take care when
> >>>>>>> clicking links or opening attachments. When in doubt, report the
> >>>>>>> message using the 'Report this email' button
> >>>>>>>
> >>>>>>>
> >>>>>>> On 25/09/2023 09:41, Ming Qian wrote:
> >>>>>>>> There are total 4 slots available in the IP, and we only need to
> >>>>>>>> use one slot in one os, assign a single slot, configure
> >>>>>>>> interrupt and power domain only for 1 slot, not for the all 4 slots.
> >>>>>>>
> >>>>>>> No changelog and I do not see much of improvements. Do not ignore
> >>>>>>> the feedback but respond to it or fix the patch. Really, what
> >>>>>>> happened
> >>> here?
> >>>>>>>
> >>>>>>
> >>>>>> Hi Krzysztof,
> >>>>>> What do you mean wrap commit message? Do you mean line
> >wrapped
> >>> at
> >>>>> 75 columns?
> >>>>>>
> >>>>>> - The body of the explanation, line wrapped at 75 columns, which will
> >>>>>> be copied to the permanent changelog to describe this patch.
> >>>>>
> >>>>> I gave you clear link to the doc explaining this. What is unclear there?
> >>>>>
> >>>>> And you decide to ignore all the rest of the comments here as well?
> >>>
> >>> So this is still ignored? Can you respond to all my comments?
> >>>
> >>>>>
> >>>>> Best regards,
> >>>>> Krzysztof
> >>>>
> >>>> The link content is as below:
> >>>>
> >>>> - The body of the explanation, line wrapped at 75 columns, which will
> >>>> be copied to the permanent changelog to describe this patch.
> >>>>
> >>>> I'm sorry that I didn’t get your point.
> >>>
> >>> Wrap
> >>> your
> >>> commit
> >>> according
> >>> to
> >>> coding
> >>> style.
> >>>
> >>> Best regards,
> >>> Krzysztof
> >>
> >> Hi Krzysztof,
> >> I opened your link about the Linux coding style / submission process, but I
> >only find the following message:
> >>
> >> - The body of the explanation, line wrapped at 75 columns, which will
> >> be copied to the permanent changelog to describe this patch.
> >>
> >> So I don't know what do you mean the coding style.
> >
> >
> >Linked document explains what is a patch, how it is formatted. Just read
> >entire doc, not one sentence.
> >
> >You keep ignoring my other comments all the time, so I will stop asking you to
> >respond to them. Instead I will be NAK-ing your patches till you decide to
> >respond.
> >
> >Best regards,
> >Krzysztof
>
> Hi Krzysztof,
> I'm sorry that I make you unhappy, as I didn't know how to improve the commit message.
> And your other comments about the change, I get your point, and prepare to improve in the next version.
>
> Sorry again that I didn't response your every comments, I will avoid doing it again.
>
> And can you give a example how to improve the commit message.
'git log'
There are 10K+ examples every 2 months.
Please talk to your NXP colleagues experienced with upsteam about how to
write and submit patches upstream, and explain what Krzysztof has said
if it is not clear.
Rob
Powered by blists - more mailing lists